mxm commented on code in PR #15780:
URL: https://github.com/apache/iceberg/pull/15780#discussion_r3016420842
##########
flink/v2.1/flink/src/main/java/org/apache/iceberg/flink/sink/dynamic/DynamicRecordProcessor.java:
##########
@@ -111,7 +121,9 @@ public void processElement(T element, Context ctx,
Collector<DynamicRecordIntern
}
@Override
- public void collect(DynamicRecord data) {
+ public void collect(DynamicRecord inputData) {
+ DynamicRecordWithDefaults data = new DynamicRecordWithDefaults(inputData,
flinkWriteConf);
Review Comment:
That makes sense. The `setConfig(..)` approach could work. It will keep all
the logic in one place. It would also be transparent to the user, e.g. still
support subclassing of DynamicRecord to change the logic.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
