swapna267 commented on code in PR #15780:
URL: https://github.com/apache/iceberg/pull/15780#discussion_r3103122198
##########
flink/v2.1/flink/src/main/java/org/apache/iceberg/flink/sink/dynamic/DynamicRecord.java:
##########
@@ -38,6 +40,7 @@ public class DynamicRecord {
private int writeParallelism;
private boolean upsertMode;
@Nullable private Set<String> equalityFields;
+ @Nullable private FlinkWriteConf flinkWriteConf;
Review Comment:
Started with that,
`DynamicRecordWithDefaults data = new DynamicRecordWithDefaults(inputData,
flinkWriteConf);`
Previous commit for more details,
https://github.com/apache/iceberg/pull/15780/changes/0f0865bea36e96bfc142f7f4435f0821dadd8e9a#diff-5f5a7f6f9ebbe16f311f866a4c667844d1e344b3b9f19dc6669f0315e4234fb2
Previous discussion around that,
https://github.com/apache/iceberg/pull/15780#discussion_r3009618931
There was concern around taking DynamicRecord and eventually constructing
DynamicRecordInternal in the same class and in between construct another
wrapper.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
