rdblue commented on code in PR #15595:
URL: https://github.com/apache/iceberg/pull/15595#discussion_r2934018510
##########
core/src/test/java/org/apache/iceberg/rest/TestRESTScanPlanning.java:
##########
@@ -896,11 +896,11 @@ public void serverSupportsPlanningSyncOnlyNotAsync() {
RESTTable table = restTableFor(catalog, "async_not_supported");
setParserContext(table);
- // Should fail with UnsupportedOperationException when trying to fetch
async plan result
- // because V1_FETCH_TABLE_SCAN_PLAN endpoint is not supported
+ // Should fail with IllegalStateException when trying to fetch async plan
result
+ // because the server does not support fetching plan results
assertThatThrownBy(restTableScanFor(table)::planFiles)
- .isInstanceOf(UnsupportedOperationException.class)
- .hasMessage("Server does not support endpoint: %s",
Endpoint.V1_FETCH_TABLE_SCAN_PLAN);
+ .isInstanceOf(IllegalStateException.class)
Review Comment:
I think this is correct. If a service puts the client in a submitted state
but can't complete the operation after that, it's an illegal state.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
