nastra commented on code in PR #15595:
URL: https://github.com/apache/iceberg/pull/15595#discussion_r2930696370
##########
core/src/main/java/org/apache/iceberg/rest/RESTSessionCatalog.java:
##########
@@ -598,6 +598,9 @@ private RESTTable restTableForScanPlanning(
TableOperations ops, TableIdentifier finalIdentifier, RESTClient
restClient) {
// server supports remote planning endpoint and server / client wants to
do server side planning
if (endpoints.contains(Endpoint.V1_SUBMIT_TABLE_SCAN_PLAN) &&
restScanPlanningEnabled) {
+ boolean supportsAsync =
endpoints.contains(Endpoint.V1_FETCH_TABLE_SCAN_PLAN);
Review Comment:
should we maybe name this `supportsFetchPlanningResult` to be more precise?
`async` could mean different things to different people and the endpoint that
we're referring to here is the one that returns the planning result for a given
planId
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
