nastra commented on code in PR #15595:
URL: https://github.com/apache/iceberg/pull/15595#discussion_r2929548822
##########
core/src/main/java/org/apache/iceberg/rest/RESTTableScan.java:
##########
@@ -74,16 +71,15 @@ class RESTTableScan extends DataTableScan {
.build();
private final RESTClient client;
- private final Map<String, String> headers;
- private final TableOperations operations;
- private final Table table;
- private final ResourcePaths resourcePaths;
- private final TableIdentifier tableIdentifier;
- private final Set<Endpoint> supportedEndpoints;
+ private final Supplier<Map<String, String>> headers;
+ private final String planTableScanPath;
+ private final Function<String, String> planPath;
+ private final String fetchScanTasksPath;
+ private final boolean supportsAsync;
+ private final boolean supportsCancel;
+ private final boolean supportsFetchTasks;
Review Comment:
@rdblue I think it is reasonable to only support the `plan` endpoint without
having immediate support for the `tasks` endpoint (independently from whether
such a design results in good perf). It is likely that servers implementing
remote scan planning will start with the easy endpoint first (`plan`) and later
add the async planning part and I think we should at least not mandate that all
endpoints must be supported immediately
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
