rdblue commented on code in PR #15006:
URL: https://github.com/apache/iceberg/pull/15006#discussion_r2824994067
##########
core/src/main/java/org/apache/iceberg/MergingSnapshotProducer.java:
##########
@@ -265,15 +268,14 @@ private void addInternal(DeleteFile file) {
"Cannot find partition spec %s for delete file: %s",
file.specId(),
file.location());
-
- DeleteFileSet deleteFiles =
- newDeleteFilesBySpec.computeIfAbsent(spec.specId(), ignored ->
DeleteFileSet.create());
- if (deleteFiles.add(file)) {
- addedFilesSummary.addedFile(spec, file);
- hasNewDeleteFiles = true;
- if (ContentFileUtil.isDV(file)) {
- newDVRefs.add(file.referencedDataFile());
- }
+ hasNewDeleteFiles = true;
+ if (ContentFileUtil.isDV(file)) {
+ List<DeleteFile> dvsForReferencedFile =
+ dvsByReferencedFile.computeIfAbsent(
+ file.referencedDataFile(), newFile -> Lists.newArrayList());
+ dvsForReferencedFile.add(file);
+ } else {
+ positionAndEqualityDeletes.add(file);
Review Comment:
In v3, position deletes are no longer allowed to be added to the table, so
should this have a check that the table is either version 2 or the deletes are
equality deletes?
I know that we don't want to add the complexity right now to rewrite v2
position deletes as DVs, but it doesn't seem like we should allow them to be
added through the public API.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
