rdblue commented on code in PR #15006:
URL: https://github.com/apache/iceberg/pull/15006#discussion_r2819734312
##########
core/src/main/java/org/apache/iceberg/deletes/Deletes.java:
##########
@@ -126,6 +133,18 @@ public static <T extends StructLike>
CharSequenceMap<PositionDeleteIndex> toPosi
return toPositionIndexes(posDeletes, null /* unknown delete file */);
}
+ public static PositionDeleteIndex readDV(
+ DeleteFile deleteFile, FileIO fileIO, EncryptionManager
encryptionManager) {
+ Preconditions.checkArgument(
+ ContentFileUtil.isDV(deleteFile), "Delete file must be a deletion
vector");
+ InputFile inputFile =
+ EncryptingFileIO.combine(fileIO,
encryptionManager).newInputFile(deleteFile);
Review Comment:
I think that the caller should combine these so that the `FileIO` can handle
the `DeleteFile` directly. We don't want utility methods creating a
one-time-use `EncryptingFileIO`. This should just assume that the `FileIO` has
been wrapped appropriately for the table.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
