rdblue commented on code in PR #15006:
URL: https://github.com/apache/iceberg/pull/15006#discussion_r2824952365
##########
core/src/main/java/org/apache/iceberg/deletes/DVFileWriter.java:
##########
@@ -43,4 +43,21 @@ public interface DVFileWriter extends Closeable {
* @return the writer result
*/
DeleteWriteResult result();
+
+ /**
+ * Marks every position that is deleted in positionDeleteIndex as deleted in
the given data file.
+ * Implementations should merge with existing position indices for the
provided path
+ *
+ * @param path the data file path
+ * @param positionDeleteIndex the position delete index containing all the
positions to delete
+ * @param spec the data file partition spec
+ * @param partition the data file partition
+ */
+ default void delete(
+ String path,
+ PositionDeleteIndex positionDeleteIndex,
+ PartitionSpec spec,
+ StructLike partition) {
+ throw new UnsupportedOperationException("Delete with positionDeleteIndex
is not supported");
Review Comment:
Error messages generally shouldn't use identifiers from code. Would this be
more helpful to users if you used "Bulk deletes are not supported" or similar?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
