kumarpritam863 commented on code in PR #15209:
URL: https://github.com/apache/iceberg/pull/15209#discussion_r2807555440


##########
kafka-connect/kafka-connect/src/main/java/org/apache/iceberg/connect/data/RecordConverter.java:
##########
@@ -385,7 +415,13 @@ protected String convertString(Object value) {
         return MAPPER.writeValueAsString(value);
       } else if (value instanceof Struct) {
         Struct struct = (Struct) value;
-        byte[] data = config.jsonConverter().fromConnectData(null, 
struct.schema(), struct);
+        byte[] data;

Review Comment:
   If you are referring to the try with resources part I did for auto closing.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to