danielcweeks commented on code in PR #15209:
URL: https://github.com/apache/iceberg/pull/15209#discussion_r2800177576
##########
kafka-connect/kafka-connect/src/main/java/org/apache/iceberg/connect/data/SchemaUtils.java:
##########
@@ -349,5 +552,9 @@ private int nextId() {
}
}
+ public static boolean includeDefaults(int formatVersion) {
Review Comment:
I see now that we're calling this from multiple places, which is why you
added the utility method, but the name doesn't make sense. `includeDefaults`
makes sense for the conversion method parameter, but this utility method should
probably be something more like `supportsDefaults`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
