kumarpritam863 commented on code in PR #15209:
URL: https://github.com/apache/iceberg/pull/15209#discussion_r2807555830
##########
kafka-connect/kafka-connect/src/main/java/org/apache/iceberg/connect/data/RecordConverter.java:
##########
@@ -217,8 +232,21 @@ private GenericRecord convertToStruct(
if (schemaUpdateConsumer != null) {
String parentFieldName =
structFieldId < 0 ? null :
tableSchema.findColumnName(structFieldId);
- Type type = SchemaUtils.toIcebergType(recordField.schema(),
config);
- schemaUpdateConsumer.addColumn(parentFieldName,
recordField.name(), type);
+ Type type =
+ SchemaUtils.toIcebergType(
+ recordField.schema(),
+ config,
+ SchemaUtils.includeDefaults(tableFormatVersion));
Review Comment:
I changed this to utility method as this is being called from multiple places
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
