gty404 commented on code in PR #437:
URL: https://github.com/apache/iceberg-cpp/pull/437#discussion_r2646711628
##########
src/iceberg/table_metadata.h:
##########
@@ -73,10 +73,13 @@ struct ICEBERG_EXPORT TableMetadata {
static constexpr int8_t kDefaultTableFormatVersion = 2;
static constexpr int8_t kSupportedTableFormatVersion = 3;
static constexpr int8_t kMinFormatVersionRowLineage = 3;
+ static constexpr int8_t kMinFormatVersionDefaultValues = 3;
static constexpr int64_t kInitialSequenceNumber = 0;
static constexpr int64_t kInvalidSequenceNumber = -1;
static constexpr int64_t kInitialRowId = 0;
+ static inline const std::unordered_map<TypeId, int8_t> kMinFormatVersions =
{};
Review Comment:
This is reserved for new types. Iceberg v3 added new types, but they are
currently not defined in iceberg-cpp.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
