HeartLinked commented on code in PR #437:
URL: https://github.com/apache/iceberg-cpp/pull/437#discussion_r2646514587
##########
src/iceberg/table_update.h:
##########
@@ -216,10 +216,10 @@ class ICEBERG_EXPORT RemovePartitionSpecs : public
TableUpdate {
/// \brief Represents removing schemas from the table
class ICEBERG_EXPORT RemoveSchemas : public TableUpdate {
public:
- explicit RemoveSchemas(std::vector<int32_t> schema_ids)
+ explicit RemoveSchemas(std::unordered_set<int32_t> schema_ids)
: schema_ids_(std::move(schema_ids)) {}
- const std::vector<int32_t>& schema_ids() const { return schema_ids_; }
+ const std::unordered_set<int32_t>& schema_ids() const { return schema_ids_; }
void ApplyTo(TableMetadataBuilder& builder) const override;
Review Comment:
What about implement `applyTo` here? Although the table update doesn’t seem
to be invoked in the current architecture and may need refactoring , I think it
makes sense to implement it here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
