WZhuo commented on code in PR #437:
URL: https://github.com/apache/iceberg-cpp/pull/437#discussion_r2646633791
##########
src/iceberg/table_metadata.cc:
##########
@@ -608,7 +631,124 @@ Status TableMetadataBuilder::Impl::RemoveProperties(
return {};
}
-std::unique_ptr<TableMetadata> TableMetadataBuilder::Impl::Build() {
+Status TableMetadataBuilder::Impl::SetCurrentSchema(int32_t schema_id) {
+ if (schema_id == kLastAdded) {
+ if (!last_added_schema_id_.has_value()) {
+ return InvalidArgument("Cannot set last added schema: no schema has been
added");
Review Comment:
```suggestion
return ValidationFailed("Cannot set last added schema: no schema has
been added");
```
The difference between ValidationFailed and InvalidArgument described in
Java Implement
// `ValidationFailed` returned when the arguments are valid in isolation,
but not in
// conjunction with other arguments or state, as opposed to
`InvalidArgument` which is
// returned when an argument value is always invalid.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
