wgtmac commented on code in PR #437:
URL: https://github.com/apache/iceberg-cpp/pull/437#discussion_r2647558316
##########
src/iceberg/partition_spec.cc:
##########
@@ -177,9 +179,10 @@ Status PartitionSpec::Validate(const Schema& schema, bool
allow_missing_fields)
return {};
}
-Status PartitionSpec::ValidatePartitionName(const Schema& schema) const {
+Status PartitionSpec::ValidatePartitionName(const Schema& schema,
+ const PartitionSpec& spec) {
Review Comment:
BTW, Java impl also has `checkForRedundantPartitions`, do we want to add
that check? We can add a TODO somewhere if necessary.
##########
src/iceberg/partition_spec.cc:
##########
@@ -177,9 +179,10 @@ Status PartitionSpec::Validate(const Schema& schema, bool
allow_missing_fields)
return {};
}
-Status PartitionSpec::ValidatePartitionName(const Schema& schema) const {
+Status PartitionSpec::ValidatePartitionName(const Schema& schema,
+ const PartitionSpec& spec) {
Review Comment:
Do we need to add an extra parameter `case_sensitive`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
