pvary commented on code in PR #14197:
URL: https://github.com/apache/iceberg/pull/14197#discussion_r2429375699
##########
flink/v2.1/flink/src/main/java/org/apache/iceberg/flink/sink/BaseDeltaTaskWriter.java:
##########
@@ -122,5 +126,14 @@ protected StructLike asStructLike(RowData data) {
protected StructLike asStructLikeKey(RowData data) {
return keyWrapper.wrap(data);
}
+
+ @Override
+ protected void closePositionWriter() throws IOException {
+ // We should not close dvFileWriter here, because we may have multiple
writers share the same
+ // dvFileWriter.
+ if (!useDv) {
+ super.closePositionWriter();
+ }
+ }
Review Comment:
Do we need to handle this here, or it is enough to handle this in the
BaseTaskWriter?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
