pvary commented on code in PR #14197:
URL: https://github.com/apache/iceberg/pull/14197#discussion_r2429324422
##########
core/src/main/java/org/apache/iceberg/io/BaseTaskWriter.java:
##########
Review Comment:
The warping is a good idea. Maybe inline some of it, like:
```
this.posDeleteWriter =
partitioningDVWriter != null
? partitioningDVWriter
: createPosDeleteWriter(partition, deleteGranularity);
```
And define it like this:
```
private PartitioningWriter<PositionDelete<T>, DeleteWriteResult>
createPosDeleteWriter(
StructLike partition, DeleteGranularity deleteGranularity) {
this.closePosDeleteWriter = true;
return new PartitionSortingPositionOnlyDeleteWriterWrap<>(
() -> appenderFactory.newPosDeleteWriter(newOutputFile(partition),
format, partition),
deleteGranularity);
}
```
Also we should find a better name for
`PartitionSortingPositionOnlyDeleteWriterWrap`. We can call it simply
`PositionDeleteWriter`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
