pvary commented on code in PR #14197:
URL: https://github.com/apache/iceberg/pull/14197#discussion_r2429336685
##########
core/src/main/java/org/apache/iceberg/io/BaseTaskWriter.java:
##########
@@ -129,24 +130,43 @@ public WriteResult complete() throws IOException {
.build();
}
+ protected void addReferencedDataFiles(CharSequenceSet files) {
+ referencedDataFiles.addAll(files);
+ }
+
+ protected void addCompletedDeleteFiles(List<DeleteFile> files) {
+ completedDeleteFiles.addAll(files);
+ }
+
/** Base equality delta writer to write both insert records and
equality-deletes. */
protected abstract class BaseEqualityDeltaWriter implements Closeable {
private final StructProjection structProjection;
private final PositionDelete<T> positionDelete;
+ private final StructLike partitionKey;
private RollingFileWriter dataWriter;
private RollingEqDeleteWriter eqDeleteWriter;
- private FileWriter<PositionDelete<T>, DeleteWriteResult> posDeleteWriter;
+ private PartitioningWriter<PositionDelete<T>, DeleteWriteResult>
posDeleteWriter;
private Map<StructLike, PathOffset> insertedRowMap;
protected BaseEqualityDeltaWriter(StructLike partition, Schema schema,
Schema deleteSchema) {
- this(partition, schema, deleteSchema, DeleteGranularity.PARTITION);
+ this(partition, schema, deleteSchema, DeleteGranularity.PARTITION, null,
false);
}
protected BaseEqualityDeltaWriter(
StructLike partition,
Schema schema,
Schema deleteSchema,
DeleteGranularity deleteGranularity) {
+ this(partition, schema, deleteSchema, deleteGranularity, null, false);
+ }
+
+ protected BaseEqualityDeltaWriter(
+ StructLike partition,
+ Schema schema,
+ Schema deleteSchema,
+ DeleteGranularity deleteGranularity,
+ PartitioningDVWriter<T> partitioningDVWriter,
Review Comment:
Maybe simply call this `posDeleteWriter`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
