amogh-jahagirdar commented on code in PR #14197:
URL: https://github.com/apache/iceberg/pull/14197#discussion_r2392050043
##########
flink/v2.1/flink/src/main/java/org/apache/iceberg/flink/sink/BaseDeltaTaskWriter.java:
##########
@@ -110,7 +113,7 @@ public void write(RowData row) throws IOException {
protected class RowDataDeltaWriter extends BaseEqualityDeltaWriter {
RowDataDeltaWriter(PartitionKey partition) {
- super(partition, schema, deleteSchema, DeleteGranularity.FILE);
+ super(partition, schema, deleteSchema, DeleteGranularity.FILE, useDv);
Review Comment:
Yeah delete granularity is only for position deletes; DVs by definition have
a file level granularity
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
