pvary commented on code in PR #14197:
URL: https://github.com/apache/iceberg/pull/14197#discussion_r2390459634
##########
core/src/main/java/org/apache/iceberg/io/BaseTaskWriter.java:
##########
@@ -257,6 +277,21 @@ public void close() throws IOException {
posDeleteWriter = null;
}
}
+
+ // Add the completed dvs files.
+ if (dvFileWriter != null) {
+ try {
+ // complete will call close
+ if (!dvFileWriter.closed()) {
+ dvFileWriter.close();
Review Comment:
What if one of the basewriters are closed earlier.
This would close the dvWrter.
Then the other, still open writers will fail writing deletes, since the
dvWriter is closed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
