Guosmilesmile commented on code in PR #14197: URL: https://github.com/apache/iceberg/pull/14197#discussion_r2393321264
########## core/src/main/java/org/apache/iceberg/io/BaseTaskWriter.java: ########## Review Comment: The two position delete writers seem very similar, but they don't have a unified interface. To keep the scope of changes manageable, I initially didn't alter this part. Now, I've tried to modify `SortingPositionOnlyDeleteWriter` to have the same interface as `PartitioningDVWriter`, namely the `PartitioningWriter` interface. However, I found that `SortingPositionOnlyDeleteWriter` is also used elsewhere, and it's called with its existing interface. So, I had to create a new class that inherits from it and implements the `PartitioningWriter` interface to achieve this. But I'm not sure if this approach is appropriate. Could you also help take a look and see if changes are needed in this area? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
