Guosmilesmile commented on code in PR #14197:
URL: https://github.com/apache/iceberg/pull/14197#discussion_r2390550366
##########
core/src/main/java/org/apache/iceberg/io/BaseTaskWriter.java:
##########
@@ -257,6 +277,21 @@ public void close() throws IOException {
posDeleteWriter = null;
}
}
+
+ // Add the completed dvs files.
+ if (dvFileWriter != null) {
+ try {
+ // complete will call close
+ if (!dvFileWriter.closed()) {
+ dvFileWriter.close();
Review Comment:
I think these Writers only call the `close` method during `complete` or
`abort`. At the end of each checkpoint, all Writes call `close` once. As far as
I understand, there shouldn't be a situation where some writes are still
writing while others are calling `close`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
