zhjwpku commented on code in PR #238:
URL: https://github.com/apache/iceberg-cpp/pull/238#discussion_r2434365157
##########
src/iceberg/util/decimal.h:
##########
@@ -164,6 +165,12 @@ class ICEBERG_EXPORT Decimal : public util::Formattable {
/// \return error status if the length is an invalid value
static Result<Decimal> FromBigEndian(const uint8_t* data, int32_t length);
+ /// \brief Convert Decimal's unscaled value to two’s-complement big-endian
binary, using
+ /// the minimum number of bytes for the value.
+ /// \param value The unscaled value.
+ /// \return A vector containing the big-endian bytes.
+ static std::vector<uint8_t> ToBigEndian(int128_t value);
Review Comment:
Changed to a member function.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
