HuaHuaY commented on code in PR #238:
URL: https://github.com/apache/iceberg-cpp/pull/238#discussion_r2434470449
##########
src/iceberg/expression/literal.h:
##########
@@ -56,10 +58,10 @@ class ICEBERG_EXPORT Literal : public util::Formattable {
int64_t, // for long, timestamp,
timestamp_tz, time
float, // for float
double, // for double
- std::string, // for string
- Uuid, // for uuid
- std::vector<uint8_t>, // for binary, fixed
- std::array<uint8_t, 16>, // for decimal
+ ::iceberg::Decimal, // for decimal
+ std::string, // for string
+ Uuid, // for uuid
Review Comment:
```suggestion
Decimal, // for decimal
std::string, // for string
Uuid, // for uuid
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
