zhjwpku commented on code in PR #238:
URL: https://github.com/apache/iceberg-cpp/pull/238#discussion_r2434360266
##########
src/iceberg/expression/literal.h:
##########
@@ -76,6 +78,8 @@ class ICEBERG_EXPORT Literal : public util::Formattable {
static Literal UUID(Uuid value);
static Literal Binary(std::vector<uint8_t> value);
static Literal Fixed(std::vector<uint8_t> value);
+ static Literal MakeDecimal(Decimal value, int32_t precision, int32_t scale);
Review Comment:
I ended up with `static Literal Decimal(int128_t value, int32_t precision,
int32_t scale);`, where `value` represents the unscaled 128-bit integer, this
seems more natural.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
