zhjwpku commented on code in PR #238:
URL: https://github.com/apache/iceberg-cpp/pull/238#discussion_r2434565340
##########
src/iceberg/expression/literal.h:
##########
@@ -56,10 +58,10 @@ class ICEBERG_EXPORT Literal : public util::Formattable {
int64_t, // for long, timestamp,
timestamp_tz, time
float, // for float
double, // for double
- std::string, // for string
- Uuid, // for uuid
- std::vector<uint8_t>, // for binary, fixed
- std::array<uint8_t, 16>, // for decimal
+ ::iceberg::Decimal, // for decimal
+ std::string, // for string
+ Uuid, // for uuid
Review Comment:
I'm using `::iceberg::Decimal` to avoid `changes-meaning` compiling warning,
see below:
```
In file included from
/home/runner/work/iceberg-cpp/iceberg-cpp/src/iceberg/expression/literal.cc:20:
/home/runner/work/iceberg-cpp/iceberg-cpp/src/iceberg/expression/literal.h:84:18:
error: declaration of ‘static iceberg::Literal
iceberg::Literal::Decimal(int128_t, int32_t, int32_t)’ changes meaning of
‘Decimal’ [-Wchanges-meaning]
84 | static Literal Decimal(int128_t value, int32_t precision,
| ^~~~~~~
/home/runner/work/iceberg-cpp/iceberg-cpp/src/iceberg/expression/literal.h:61:30:
note: used here to mean ‘class iceberg::Decimal’
61 | Decimal, // for decimal
| ^~~~~~~
In file included from
/home/runner/work/iceberg-cpp/iceberg-cpp/src/iceberg/expression/literal.h:30:
/home/runner/work/iceberg-cpp/iceberg-cpp/src/iceberg/util/decimal.h:45:22:
note: declared here
45 | class ICEBERG_EXPORT Decimal : public util::Formattable {
| ^~~~~~~
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
