Guosmilesmile commented on code in PR #14197:
URL: https://github.com/apache/iceberg/pull/14197#discussion_r2393205498
##########
core/src/main/java/org/apache/iceberg/io/BaseTaskWriter.java:
##########
@@ -140,7 +161,13 @@ protected BaseEqualityDeltaWriter(
new SortingPositionOnlyDeleteWriter<>(
() ->
appenderFactory.newPosDeleteWriter(newOutputFile(partition), format, partition),
deleteGranularity);
+ this.dvFileWriter =
+ null == partitioningDVWriter
+ ? new PartitioningDVWriter<>(fileFactory, p -> null)
Review Comment:
Flink only writes position delete files for the new data files created in
the same checkpoint cycle.During streaming writes, position deletes are not
added to the dataFile from the previous checkpoint cycle, so there is no
additional operation for merging.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
