RussellSpitzer commented on code in PR #14108:
URL: https://github.com/apache/iceberg/pull/14108#discussion_r2360602716
##########
spark/v4.0/spark/src/test/java/org/apache/iceberg/spark/actions/TestRewriteDataFilesAction.java:
##########
@@ -2645,4 +2645,50 @@ public boolean matches(RewriteFileGroup argument) {
return groupIDs.contains(argument.info().globalIndex());
}
}
+
+ @TestTemplate
Review Comment:
Nit point; tests should go with the other tests, look like these just got
put at the bottom of the file below some private helper methods.
Larger question, I'm not sure we want to add this many tests that fully
integration test the rewrite. These are already quite expensive so adding new
ones is always an issue.
I think adding one is probably fine. Another thing to consider is maybe we
should just have an explicit test for the UDF. I think we would be able to
write a much faster test just trying to put every type through the UDF without
doing the rewrite too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
