kevinjqliu commented on code in PR #1680:
URL: https://github.com/apache/iceberg-rust/pull/1680#discussion_r2357425377
##########
.github/actions/setup-builder/action.yml:
##########
@@ -33,7 +33,6 @@ runs:
run: |
echo "Installing ${RUST_VERSION}"
rustup toolchain install ${RUST_VERSION}
- rustup override set ${RUST_VERSION}
Review Comment:
i **think** this is safe to remove, `./.github/actions/setup-builder` is
only called once in github action workflows. So the `cargo` commands will
default to the only toolchain thats installed.
Except for in `ci.yml`, its called twice, to install nightly and MSRV. But
in `make check-msrv`, we specify which toolchain to use.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
