Fokko commented on code in PR #1680:
URL: https://github.com/apache/iceberg-rust/pull/1680#discussion_r2355497621
##########
Makefile:
##########
@@ -41,6 +41,11 @@ fix-toml: install-taplo-cli
check-toml: install-taplo-cli
taplo check
+check-msrv:
Review Comment:
Should we call this from CI as well? Otherwise we're duplicating logic, and
it is nice to have the same logic both for local development as CI.
https://github.com/apache/iceberg-rust/blob/bad8e4e6680589082121903871ac67f84abaccc0/.github/workflows/ci.yml#L173C40-L173C61
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
