kevinjqliu commented on code in PR #1680:
URL: https://github.com/apache/iceberg-rust/pull/1680#discussion_r2356645573
##########
.github/workflows/ci.yml:
##########
@@ -155,19 +155,15 @@ jobs:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v5
- - name: Setup Nightly Rust toolchain
- uses: ./.github/actions/setup-builder
- name: Install protoc
uses: arduino/setup-protoc@v3
with:
repo-token: ${{ secrets.GITHUB_TOKEN }}
- - name: Generate minimal versions lockfile
- run: |
- cargo generate-lockfile -Z direct-minimal-versions
+ - name: Setup Nightly Rust toolchain
+ uses: ./.github/actions/setup-builder
- name: Setup MSRV Rust toolchain
uses: ./.github/actions/setup-builder
with:
rust-version: ${{ env.rust_msrv }}
Review Comment:
needs both nightly and MSRV toolchain because
`cargo generate-lockfile -Z direct-minimal-versions` requires nightly
specified by `rust-toolchain.toml`
`cargo +1.87 check --locked --workspace` then requires MSRV
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
