RussellSpitzer commented on PR #13922: URL: https://github.com/apache/iceberg/pull/13922#issuecomment-3246218538
I think my big comment here is I have no problem with introducing the wap.branch property, but I don't think we should couple the "staging" logic in the function which sets that property. I think if we isolate the change to just setting either wap.id or branch, we are all set. -- Note we may also add to the Spec index https://github.com/apache/iceberg/blob/main/format/spec.md#other-fields -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
