RussellSpitzer commented on code in PR #13922:
URL: https://github.com/apache/iceberg/pull/13922#discussion_r2316745469
##########
spark/v4.0/spark/src/main/java/org/apache/iceberg/spark/SparkWriteConf.java:
##########
@@ -461,11 +461,22 @@ public boolean caseSensitive() {
.parse();
}
+ private String getWapBranch() {
+ return
confParser.stringConf().sessionConf(SparkSQLProperties.WAP_BRANCH).parseOptional();
+ }
+
+ public boolean isWapBranch(String branchName) {
Review Comment:
I'm not sure why we need this method? Aren't we just always returning true
of the wapBranch is not null and matches the branch being written too?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
