RussellSpitzer commented on code in PR #13922:
URL: https://github.com/apache/iceberg/pull/13922#discussion_r2316726712
##########
spark/v4.0/spark/src/main/java/org/apache/iceberg/spark/source/SparkPositionDeltaWrite.java:
##########
@@ -326,12 +328,7 @@ private void commitOperation(SnapshotUpdate<?> operation,
String description) {
CommitMetadata.commitProperties().forEach(operation::set);
- if (wapEnabled && wapId != null) {
- // write-audit-publish is enabled for this table and job
- // stage the changes without changing the current snapshot
- operation.set(SnapshotSummary.STAGED_WAP_ID_PROP, wapId);
- operation.stageOnly();
Review Comment:
I mentioned this above, but i'm not comfortable extracting `stageOnly` here.
That seems a bit different than "setWapProperties". Perhaps a rename may make
this a bit more clear, but currently it feels like we are hiding an important
state change on `operation`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
