stevie9868 commented on code in PR #13922: URL: https://github.com/apache/iceberg/pull/13922#discussion_r2312547986
########## spark/v4.0/spark/src/main/java/org/apache/iceberg/spark/source/SparkPositionDeltaWrite.java: ########## @@ -114,6 +114,7 @@ class SparkPositionDeltaWrite implements DeltaWrite, RequiresDistributionAndOrde private final SparkWriteRequirements writeRequirements; private final Context context; private final Map<String, String> writeProperties; + private final boolean isWapBranch; Review Comment: I eventually decide to make [SparkPositionDeltaWrite.java] consistent with Sparkwrite where the `writeConf` is captured as an instance variable ########## spark/v4.0/spark/src/main/java/org/apache/iceberg/spark/source/SparkPositionDeltaWrite.java: ########## @@ -114,6 +114,7 @@ class SparkPositionDeltaWrite implements DeltaWrite, RequiresDistributionAndOrde private final SparkWriteRequirements writeRequirements; private final Context context; private final Map<String, String> writeProperties; + private final boolean isWapBranch; Review Comment: I eventually decide to make [SparkPositionDeltaWrite.java] consistent with Sparkwrite where the `writeConf` is captured as an instance variable. Let me know what you think -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
