RussellSpitzer commented on code in PR #13935:
URL: https://github.com/apache/iceberg/pull/13935#discussion_r2305510790
##########
arrow/src/main/java/org/apache/iceberg/arrow/vectorized/VectorizedArrowReader.java:
##########
@@ -142,6 +142,9 @@ public VectorHolder read(VectorHolder reuse, int
numValsToRead) {
if (reuse == null
|| (!dictEncoded && readType == ReadType.DICTIONARY)
|| (dictEncoded && readType != ReadType.DICTIONARY)) {
+ if (vec != null) {
Review Comment:
Now we only clean up here, I decided that conceptually this is the place
where we are deciding whether to allocate or not so it's probably the right
place to check if we previously had allocated
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
