nandorKollar commented on code in PR #13935:
URL: https://github.com/apache/iceberg/pull/13935#discussion_r2304924323
##########
arrow/src/main/java/org/apache/iceberg/arrow/vectorized/VectorizedArrowReader.java:
##########
@@ -249,6 +249,9 @@ private static Types.NestedField getPhysicalType(
}
private void allocateDictEncodedVector() {
+ if (vec != null) {
Review Comment:
Either way, it solves the leak. :) I made this recommendation, because I
didn't see the point of replicating this conditional closing in each of the
leaf allocator methods, as this sounds like a common step for every vector
allocation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
