RussellSpitzer commented on code in PR #13935:
URL: https://github.com/apache/iceberg/pull/13935#discussion_r2307893793
##########
arrow/src/main/java/org/apache/iceberg/arrow/vectorized/VectorizedReaderBuilder.java:
##########
@@ -70,11 +70,28 @@ protected VectorizedReaderBuilder(
Map<Integer, ?> idToConstant,
Function<List<VectorizedReader<?>>, VectorizedReader<?>> readerFactory,
BiFunction<org.apache.iceberg.types.Type, Object, Object> convert) {
+ this(
+ expectedSchema,
+ parquetSchema,
+ setArrowValidityVector,
+ idToConstant,
+ readerFactory,
+ convert,
+ ArrowAllocation.rootAllocator());
+ }
+
+ protected VectorizedReaderBuilder(
Review Comment:
I can annotate that, I think we may want to also keep this open for a future
patch where we close allocators when the readers are closed ... not sure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
