RussellSpitzer commented on code in PR #13935:
URL: https://github.com/apache/iceberg/pull/13935#discussion_r2304913238
##########
arrow/src/main/java/org/apache/iceberg/arrow/vectorized/VectorizedArrowReader.java:
##########
@@ -249,6 +249,9 @@ private static Types.NestedField getPhysicalType(
}
private void allocateDictEncodedVector() {
+ if (vec != null) {
Review Comment:
I think that could be done, stylistically I like when the state check is
close to the new assignment. So when reading the leaf methods we know what's
going on. Personally i'm not very comfortable with really stateful code like
this but if other folks want to move that up, I don't have a problem with it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
