RussellSpitzer commented on code in PR #13935:
URL: https://github.com/apache/iceberg/pull/13935#discussion_r2304805937
##########
spark/v3.5/spark/src/test/java/org/apache/iceberg/spark/data/vectorized/parquet/TestParquetDictionaryEncodedVectorizedReads.java:
##########
@@ -165,24 +170,30 @@ public void testDecimalNotAllPagesDictionaryEncoded()
throws Exception {
List<Row> expected = df.collectAsList();
long expectedSize = df.count();
- Parquet.ReadBuilder readBuilder =
- Parquet.read(Files.localInput(path.toFile()))
- .project(schema)
- .createBatchedReaderFunc(
- type ->
- VectorizedSparkParquetReaders.buildReader(
- schema, type, ImmutableMap.of(), null));
-
- try (CloseableIterable<ColumnarBatch> batchReader = readBuilder.build()) {
- Iterator<Row> expectedIter = expected.iterator();
- Iterator<ColumnarBatch> batches = batchReader.iterator();
- int numRowsRead = 0;
- while (batches.hasNext()) {
- ColumnarBatch batch = batches.next();
- numRowsRead += batch.numRows();
- TestHelpers.assertEqualsBatchWithRows(schema.asStruct(), expectedIter,
batch);
- }
- assertThat(numRowsRead).isEqualTo(expectedSize);
- }
+ assertNoLeak(
Review Comment:
This test fails without the changes in VectorizedArrowReader. Feel free to
pull out those changes and watch this test fail :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
