RussellSpitzer commented on code in PR #13935:
URL: https://github.com/apache/iceberg/pull/13935#discussion_r2304794293


##########
arrow/src/main/java/org/apache/iceberg/arrow/vectorized/VectorizedReaderBuilder.java:
##########
@@ -70,11 +70,28 @@ protected VectorizedReaderBuilder(
       Map<Integer, ?> idToConstant,
       Function<List<VectorizedReader<?>>, VectorizedReader<?>> readerFactory,
       BiFunction<org.apache.iceberg.types.Type, Object, Object> convert) {
+    this(
+        expectedSchema,
+        parquetSchema,
+        setArrowValidityVector,
+        idToConstant,
+        readerFactory,
+        convert,
+        ArrowAllocation.rootAllocator());
+  }
+
+  protected VectorizedReaderBuilder(

Review Comment:
   We add a new constructor which let's us specify the allocator used for the 
ReaderBuilder's children. This lets us do testing without relying on 
synchronization on the allocator. Each test now uses it's own child allocator 
which we can track independently



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to