amogh-jahagirdar commented on code in PR #13555:
URL: https://github.com/apache/iceberg/pull/13555#discussion_r2220902801
##########
spark/v4.0/spark/src/main/java/org/apache/iceberg/spark/SparkCatalog.java:
##########
@@ -129,6 +129,7 @@ public class SparkCatalog extends BaseCatalog {
private static final Pattern SNAPSHOT_ID =
Pattern.compile("snapshot_id_(\\d+)");
private static final Pattern BRANCH = Pattern.compile("branch_(.*)");
private static final Pattern TAG = Pattern.compile("tag_(.*)");
+ private static final Pattern REWRITE_JOB = Pattern.compile("rewrite_(.*)");
Review Comment:
Ok, looks like CI caught this already but looking at
`TestFileRewriteCoordinator`, my assumption that we only care about the
publicly facing identifiers in `SparkCatalog` wasn't quite right. Someone could
today specify their own group ID on the spark conf and then use their own
`FileRewriteCoordinator`, in which case we do end up needing to have a similar
set of matching logic on the identifier in SparkCatalog for this case.
This should be an exact match on `rewrite`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
