amogh-jahagirdar commented on code in PR #13555:
URL: https://github.com/apache/iceberg/pull/13555#discussion_r2220568453
##########
spark/v4.0/spark/src/test/java/org/apache/iceberg/spark/actions/TestRewriteDataFilesAction.java:
##########
@@ -467,76 +471,111 @@ public void
testDataFilesNotRewrittenWithLowDeleteRatio() throws Exception {
}
@TestTemplate
- public void testBinPackWithDeletes() throws IOException {
- assumeThat(formatVersion).isGreaterThanOrEqualTo(2);
+ public void testBinPackWithDVs() throws IOException {
Review Comment:
I reordered it, the if format >= 3 /else from the previous diff will still
show since the previous test tested both but I do think the diff is a bit
easier to look at now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
