rdblue commented on code in PR #13555:
URL: https://github.com/apache/iceberg/pull/13555#discussion_r2220598158
##########
spark/v4.0/spark/src/main/java/org/apache/iceberg/spark/SparkCatalog.java:
##########
@@ -129,6 +129,7 @@ public class SparkCatalog extends BaseCatalog {
private static final Pattern SNAPSHOT_ID =
Pattern.compile("snapshot_id_(\\d+)");
private static final Pattern BRANCH = Pattern.compile("branch_(.*)");
private static final Pattern TAG = Pattern.compile("tag_(.*)");
+ private static final Pattern REWRITE_JOB = Pattern.compile("rewrite_(.*)");
Review Comment:
Looking at the `IcebergSource` code that sets `selector` it looks like
identifiers are going to be something like `catalog.db.table.rewrite` but this
won't match those identifiers. Are there two different strategies for
constructing identifiers?
Overall, I like the approach here but this seems suspicious.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
