amogh-jahagirdar commented on code in PR #13555:
URL: https://github.com/apache/iceberg/pull/13555#discussion_r2223632723
##########
spark/v4.0/spark/src/main/java/org/apache/iceberg/spark/source/SparkTable.java:
##########
@@ -191,10 +198,18 @@ private Schema snapshotSchema() {
if (icebergTable instanceof BaseMetadataTable) {
return icebergTable.schema();
} else if (branch != null) {
- return SnapshotUtil.schemaFor(icebergTable, branch);
+ return addLineageIfRequired(SnapshotUtil.schemaFor(icebergTable,
branch));
Review Comment:
Correct, the procedures don't allow specifying branches right now but this
is put in place so that if/when they do row lineage is covered. I preferred
doing this since instead of on the PR which would add compaction for branches;
it'd be easy to forget to validate that lineage is preserved as part of that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
