gabeiglio commented on code in PR #13556:
URL: https://github.com/apache/iceberg/pull/13556#discussion_r2211382128
##########
core/src/main/java/org/apache/iceberg/util/SnapshotUtil.java:
##########
@@ -303,6 +309,32 @@ public static List<DataFile> newFiles(
return newFiles;
}
+ public static CloseableIterable<DataFile> newFilesBetween(
+ Long baseSnapshotId, long latestSnapshotId, Function<Long, Snapshot>
lookup, FileIO io) {
+ List<Snapshot> snapshots = Lists.newArrayList();
+ ParallelIterable<DataFile> newFiles =
Review Comment:
We return `newFiles` in two places: inside the for-loop if somewhere along
the ancestors chain we arrive to the base snapshot. And after the for-loop in
the case the last snapshot seen is not the requested base.
We could change the logic inside the for-loop to break instead of returning,
but I don't think is worthwhile wdyt?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
