gabeiglio commented on code in PR #13556:
URL: https://github.com/apache/iceberg/pull/13556#discussion_r2206024061
##########
core/src/main/java/org/apache/iceberg/util/SnapshotUtil.java:
##########
@@ -281,17 +282,21 @@ private static Iterable<Long> toIds(Iterable<Snapshot>
snapshots) {
return Iterables.transform(snapshots, Snapshot::snapshotId);
}
- public static List<DataFile> newFiles(
+ public static CloseableIterable<DataFile> newFiles(
Review Comment:
Agreed. I think keeping the names as similar as possible would be the way to
go as both effectively do the same thing. Thinking that `newFilesBetween` is a
good candidate.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
