bryanck commented on code in PR #13556: URL: https://github.com/apache/iceberg/pull/13556#discussion_r2210867745
########## core/src/main/java/org/apache/iceberg/util/SnapshotUtil.java: ########## @@ -281,6 +282,10 @@ private static Iterable<Long> toIds(Iterable<Snapshot> snapshots) { return Iterables.transform(snapshots, Snapshot::snapshotId); } + /** + * @deprecated please use `newFilesBetween` Review Comment: You should add the version when it is expected to be removed, you can check the code for some examples, like... ``` /** * @deprecated will be removed in 2.0.0, use {@link org.apache.iceberg.metrics.Counter} instead. */ ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org