matthias-Q commented on code in PR #2173:
URL: https://github.com/apache/iceberg-python/pull/2173#discussion_r2209775948
##########
pyiceberg/utils/schema_conversion.py:
##########
@@ -69,8 +69,10 @@
LOGICAL_FIELD_TYPE_MAPPING: Dict[Tuple[str, str], PrimitiveType] = {
("date", "int"): DateType(),
("time-micros", "long"): TimeType(),
+ ("timestamp-millis", "int"): TimestampType(),
Review Comment:
@Fokko would it be fine to add a new visitor here:
https://github.com/apache/iceberg-python/blob/ad8263b1be048c8cb67d40efe70f494a4f1cb374/pyiceberg/io/pyarrow.py#L733
even though it is not in line with the java implementation anymore?
I am suggesting a `visit_timestamp_ms` (also for time and for tz)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
