kevinjqliu commented on code in PR #2173:
URL: https://github.com/apache/iceberg-python/pull/2173#discussion_r2223448960


##########
pyiceberg/utils/schema_conversion.py:
##########
@@ -69,8 +69,10 @@
 LOGICAL_FIELD_TYPE_MAPPING: Dict[Tuple[str, str], PrimitiveType] = {
     ("date", "int"): DateType(),
     ("time-micros", "long"): TimeType(),
+    ("timestamp-millis", "int"): TimestampType(),

Review Comment:
   I've created https://github.com/apache/iceberg-python/issues/2239 lets move 
the conversation there and also get some feedback form the community. 
   
   im also going to move forward to 
https://github.com/apache/iceberg-python/pull/2223 to revert the 
`timestamp-millis` mapping to unblock the 0.10 release 
   
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to